Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolved socket multiple instances getting created #585

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix: resolved socket multiple instances getting created #585

merged 1 commit into from
Jul 25, 2023

Conversation

0xNilesh
Copy link
Member

No description provided.

@github-actions
Copy link

File: packages/uiweb/src/lib/components/space/SpaceBanner/SpaceBanner.tsx

  • Line 7: Unused import statement for styled-components.

  • Line 8: Unused import statement for SpaceDTO from '@pushprotocol/restapi'.

  • Line 9: Unused import statement for PushAPI from '@pushprotocol/restapi'.

  • Line 11: Unused import statement for WidgetContent.

  • Line 12: Unused import statement for WidgetHeader.

  • Line 14: Unused import statement for isHostOfSpace.

  • Line 15: Unused import statement for isMemberOfSpace.

  • Line 25: Unused import statement for ThemeContext.

  • Line 23: Unused variable 'isTimeToStartSpace'.

  • Line 29: Unused variable 'spaceStatusRef'.

  • Line 40: Unused function parameter 'options'.

  • Line 46: Unused variable 'widgetHidden'.

  • Line 47: Unused variable 'isMinimized'.

  • Line 48: Unused variable 'spaceData'.

  • Line 50: Unused function parameter 'setSpaceData'.

  • Line 42-44: Unused variables 'getSpaceInfo', 'account', 'env', 'spaceInfo'.

File: packages/uiweb/src/lib/dataProviders/SpaceComponentsWrapper.tsx

  • Line 13: Unused function parameter 'acceptSpaceRequest'.

File: packages/uiweb/src/lib/dataProviders/SpaceDataProvider.tsx

  • Line 19: Unused import statement for ThemeContext.

  • Line 20: Unused import statement for ISpacesTheme, lightTheme.

  • Line 22: Unused import statement for ISpaceDataContextValues, ISpaceInfo, ISpacePaginationData, ISpaceSpeakerData, SpaceDataContext.

  • Line 23: Unused import statement for ENV.

  • Line 25: Unused import statement for LivepeerConfig, createReactClient, studioProvider.

  • Line 26: Unused import statement for spaceChainId.

  • Line 27: Unused import statement for walletToPCAIP10.

  • Line 36: Unused enum member 'HostedByYou'.

  • Line 52: Unused function parameter 'spaceUI'.

  • Line 147: Unused variable 'spacesObjectRef'.

  • Line 198: Unused function parameter 'resetStates'.

  • Line 56-74, 79-85, 88-90, 139-144: Unused state variables and their setters.

File: packages/uiweb/src/lib/hooks/space/usePushSpaceSocket.tsx

  • File is empty.

arn4b
arn4b approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@arn4b arn4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arn4b arn4b merged commit 5ab8352 into feat/spaces Jul 25, 2023
1 check passed
@0xNilesh 0xNilesh deleted the fix/socket-connection-multiple-instances branch July 25, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arn4b arn4b arn4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNilesh @arn4b